enable drag and drop on load file modal #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
interim17
changed the title
Coverage report
Test suite run success137 tests passing in 8 suites. Report generated by 🧪jest coverage report action from 73a2dd1 |
interim17
requested review from
frasercl and
meganrm
and removed request for
a team
frasercl
reviewed
Jul 14, 2025
Co-authored-by: Cameron Fraser <[email protected]>
Co-authored-by: Cameron Fraser <[email protected]>
meganrm
approved these changes
Aug 4, 2025
Contributor
meganrm
left a comment
meganrm
left a comment
There was a problem hiding this comment.
tested it, but I needed to update the viewer in order for this to run locally for me
… into feature/drop-on-modal
… into feature/drop-on-modal
… into feature/drop-on-modal
… into feature/drop-on-modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimate or Size
small
Problem
Advances #613
UX requested: Enable drag and drop when the “Choose a Simularium file to load” modal is shown
Solution
Use existing redux state to prevent pointer events on modal and wrap when file is dragged over, renders overlay and allows drop.
Bumped z-index of overlay to get it on top of the ant modal mask which is z-index of 1000.
Use a window event listener to close modal on drop (can't use wrap props when pointer events are disabled).
Updated modal styling:
