-
Notifications
You must be signed in to change notification settings - Fork 1
Refactor ReaDDy processing and all visualization #62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 59 commits
Commits
Show all changes
67 commits
Select commit
Hold shift + click to select a range
7c42408
update readdy module to match cytosim as much as possible
0b17f02
script to copy readdy outputs
aa344d5
visualize individual trajectories, leverage readdy post processing co…
de1b0a5
visualize combined
037f3bf
add readdy baseline individual viz
fa06164
WIP tomography viz
9bd0675
tomography visualization
5cea593
Merge branch 'main' into update-viz
4bd4c60
calculate compression metrics on tomography data for viz
27050ce
WIP debugging tomography visualization and analysis
97b09e3
dim reduction viz, tomography viz in separate files
1ec3599
WIP adding options to pca viz
503c5b6
Update name to series_name in workflow docstrings
jessicasyu 1866f55
Move copy readdy outputs into workflow notebooks
jessicasyu 73c4527
Lint readdy processing notebooks
jessicasyu 5164acf
Update docstrings in readdy data structures module
jessicasyu b599032
Update docstrings in readdy loader module
jessicasyu 1366b98
Update docstrings and type hinting in readdy post processor module
jessicasyu 5190623
Fix readdy no compression simulation series name
jessicasyu f6e7376
Update readdy simulation workflows
jessicasyu 548f3aa
Fix autodoc for readdy simulation module
jessicasyu 5497614
Fix floating point error when calculating control points
jessicasyu 9ca451b
Fix readdy series name in dim reduction analysis
jessicasyu 36065d0
Add compression metric descriptions and bounds to enum
jessicasyu 6f7b3d5
Update compression workflow to include non compression cases
jessicasyu e89b6a0
Fix readdy post processor normal calculation to skip start and end
jessicasyu e9921d2
Remove outdated visualization files
jessicasyu 881125b
Update individual simulator visualization workflows
jessicasyu b0ff9e6
Adjust number of sampled timepoints for Cytosim to match ReaDDy
jessicasyu fba0a71
Refactor combined trajectory visualization
jessicasyu 11986b6
Add visualization notebooks to docs
jessicasyu 07ca4eb
Add normalized time to compression metrics workflow
jessicasyu 1d378e2
Update PCA transform points
jessicasyu a84eb7c
* refactor tomography visualization functions
mogres cf1ca60
Update tomography visualization
jessicasyu e4a7597
add column to check if files are ordered
mogres 669374d
Merge branch 'main' into debug-update-viz
jessicasyu 120ad45
Formatting for compression metrics analysis
jessicasyu 6699c55
Update pca analysis workflow to save results to bucket
jessicasyu 18c54a5
Update visualization README
jessicasyu 7e5d06a
Refactor PCA visualization
jessicasyu 0b1001f
merged in changes from testing PCA viz with options
d81f78c
update colors and camera position for combined viz
64c8762
PCA viz tested with all options
d4cf64d
test and tweak individual readdy viz
723343b
test and tweak individual cytosim viz
4dd48a3
updated camera views for individual and PCA viz
dfba623
finish commit
05bccff
add ipdb to requirements
mogres 83fab65
Methods to calculate twist angle
mogres d8895fe
Methods to visualize twist angle
mogres 1cb6bff
Remove tangent angle visualization. Fix doc strings.
mogres 5cf8e74
Merge branch 'debug-update-viz' of github.com:simularium/subcell-pipe…
mogres a3e4740
lint
e85f117
more lint
65b4f9d
and more linting
491173e
fix saving tomography 2D plots
7c87800
tweaks to dim reduction and tomography viz
aa34e3b
lint
9d87bfe
Update subcell_pipeline/analysis/compression_metrics/README.md
7085345
changes from review
76b2ced
add h5py with pdm, remove unused imageio dep, remove broken tests
305b0d0
don't run tests on build since there aren't any
497bcb5
calculate total steps for readdy
d0328b5
remove .pdm-python and add to gitignore
d2c6c0a
Merge remote-tracking branch 'origin/feature/polymer_twist' into debu…
f2dfd59
more changes from review
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -123,3 +123,4 @@ ENV/ | |
| *.cym | ||
| *.simularium | ||
| **/analysis_outputs/** | ||
| *.h5 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| /Users/blairl/Documents/Dev/subcell-pipeline/.venv/bin/python | ||
blairlyons marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| Visualization workflow notebooks | ||
| ================================ | ||
|
|
||
| .. include:: ../subcell_pipeline/visualization/README.md | ||
| :parser: myst_parser.sphinx_ |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would keep the build workflow as is (it'll break the coverage badge otherwise). It just won't find any tests to run, which I think is fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it breaks the build otherwise. We can add one test that passes, or maybe the coverage badge should be removed since we know it's zero, unfortunately
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can refactor the existing test so it passes? It doesn't need to be in this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I leave it like this for this PR and you can pull this back in with the fixed test?