fix: prevent default folder uploads from creating albums when not asked to #1132
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I'm seeing an album with an empty name created when uploading images, even when no option that indicates an album should be created (like
--folder-as-albumor--into-album) is added.Here's what I see in logs:
Root cause
adapters/folder/commands.go:60Because the enum values are uppercase ("NONE", "FOLDER", "PATH"), the later check ifc.UsePathAsAlbumName != FolderModeNone evaluates true for the default, so the album-building branch always runs.adapters/folder/run.go:394-431.app/upload/run.go:533-542,app/upload/run.go:499-544.Fix Summary
Testing