fix(googlephotos): properly transition discovered assets to discarded state #1244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… state Assets discovered during Google Photos takeout processing were being left in PENDING state when they should have been transitioned to DISCARDED. Two scenarios were affected: 1. Duplicate files in the same directory: When a file with the same base name was found in a directory, RecordAssetDiscardedImmediately was being called. However, the asset was already discovered and in PENDING state, so RecordAssetDiscarded should be used instead to properly transition it. 2. Files without JSON metadata: When --include-unmatched is false, files without matching JSON metadata were not being transitioned to DISCARDED state, leaving them stuck in PENDING. This resulted in assets being reported as "pending" at the end of upload, even though they were correctly identified as duplicates or filtered.
rwwiv
force-pushed
the
fix/pending-assets-tracking
branch
from
17f34af to
d471fcf
Compare
Owner
|
/run_e2e |
4 similar comments
Owner
|
/run_e2e |
Owner
|
/run_e2e |
Owner
|
/run_e2e |
Owner
|
/run_e2e |
Owner
|
/run-e2e |
Owner
|
Thank you! I have missed those cases. Could you add e2e tests in the |
Author
|
Sure thing! Should have them up today or tomorrow 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assets discovered during Google Photos takeout were being left in PENDING state instead of being transitioned to DISCARDED when:
--include-unmatched=false)The fix ensures these assets properly transition from PENDING to DISCARDED using
RecordAssetDiscarded(for already-discovered assets) rather thanRecordAssetDiscardedImmediately(for assets rejected at discovery time).Added tests documenting the correct behavior for these state transitions.