Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple combobox implementation #3

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

lbelenda
Copy link

No description provided.

end

def combobox_trigger(&block)
content_for :trigger, capture(&block) if block
content_for @combobox_id, capture(&block) if block
Copy link
Collaborator

@TrabajandoIdeas TrabajandoIdeas Dec 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Esto como funciona si renderizas varios combobox?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mediante el id que se le pasa a render_combobox. Es el approach que encontre, seguramente se pueda pulir un poco mas

Copy link
Collaborator

@TrabajandoIdeas TrabajandoIdeas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solo un par de comments :P pero en general todo joya

app/helpers/components/list_helper.rb Outdated Show resolved Hide resolved
app/helpers/components/list_helper.rb Outdated Show resolved Hide resolved
app/views/examples/components/filter_multiple.html.erb Outdated Show resolved Hide resolved
@lbelenda lbelenda force-pushed the lb/multiple-combobox branch from c8db8b2 to 1b91cbf Compare December 27, 2024 18:09
@lbelenda lbelenda force-pushed the lb/multiple-combobox branch from e38c21e to 3ac30a1 Compare December 30, 2024 14:36
@lbelenda lbelenda added the waiting owner review Waiting for the project owner's response to do final improvements and then merge it. label Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting owner review Waiting for the project owner's response to do final improvements and then merge it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants