Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove numpy dependency #1580

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

christophfroeschl
Copy link
Contributor

@christophfroeschl christophfroeschl commented Feb 3, 2025


Important

Remove numpy dependency from pyproject.toml in multiple extensions.

  • Dependencies:
    • Remove numpy dependency from pyproject.toml in bedrock, google, ibm, langchain, and openai extensions.

This description was created by Ellipsis for bf4a386. It will automatically update as commits are pushed.

@christophfroeschl christophfroeschl marked this pull request as ready for review February 3, 2025 12:23
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to bf4a386 in 56 seconds

More details
  • Looked at 60 lines of code in 5 files
  • Skipped 5 files when reviewing.
  • Skipped posting 10 drafted comments based on config settings.
1. extensions/llms/bedrock/pyproject.toml:12
  • Draft comment:
    Remove numpy dependency. Ensure no code uses numpy implicitly.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
2. extensions/llms/google/pyproject.toml:12
  • Draft comment:
    Removed numpy dependency; verify integration doesn’t rely on numpy.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
3. extensions/llms/ibm/pyproject.toml:12
  • Draft comment:
    Numpy dependency removed; ensure IBM integration remains unaffected.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
4. extensions/llms/langchain/pyproject.toml:15
  • Draft comment:
    Numpy dependency removed; confirm that data handling doesn't require numpy.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
5. extensions/llms/openai/pyproject.toml:13
  • Draft comment:
    Removal of numpy dependency; verify OpenAI integration functions correctly.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    None
6. extensions/llms/bedrock/pyproject.toml:13
  • Draft comment:
    Removed the numpy dependency as intended. Ensure that no functionality relies on numpy explicitly and that documentation/release notes are updated accordingly.
  • Reason this comment was not posted:
    Comment did not seem useful.
7. extensions/llms/google/pyproject.toml:13
  • Draft comment:
    The numpy dependency has been removed here. Confirm that the integration with 'google-cloud-aiplatform' functions as expected without numpy.
  • Reason this comment was not posted:
    Marked as duplicate.
8. extensions/llms/ibm/pyproject.toml:13
  • Draft comment:
    Numpy dependency removal is consistent here. Please verify that no IBM integration feature silently requires numpy.
  • Reason this comment was not posted:
    Marked as duplicate.
9. extensions/llms/langchain/pyproject.toml:15
  • Draft comment:
    The numpy dependency has been removed. Ensure that Langchain integration features do not depend on numpy functionality.
  • Reason this comment was not posted:
    Marked as duplicate.
10. extensions/llms/openai/pyproject.toml:14
  • Draft comment:
    The explicit numpy dependency has been removed as expected. Since this resolves Loosen dependency of pandasai-openai on numpy #1563, double-check that no internal calls assume its presence.
  • Reason this comment was not posted:
    Marked as duplicate.

Workflow ID: wflow_lT9UhBqN147F64XB


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@gventuri gventuri requested a review from ArslanSaleem February 3, 2025 18:33
@ArslanSaleem ArslanSaleem merged commit 36b26ed into sinaptik-ai:main Feb 5, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loosen dependency of pandasai-openai on numpy
2 participants