Remove extension for Sinatra

[epergo]

Contributes to #114

After the Sinatra extension has been extracted to its own gem/repository now we can remove the extension code from Mustermann itself.

[zzak]

I'm wondering what will be the experience if this code is simply removed, would it be better if we provided the same interface but raise an exception to the user telling them to add the extension gem?

[epergo]

I'm wondering what will be the experience if this code is simply removed, would it be better if we provided the same interface but raise an exception to the user telling them to add the extension gem?

Right! The joy of deleting code blinded me and I didn't think about that 😄 I can restore the extend_object method but instead of loading the removed code we can raise an exception with an explanatory message, would that work?

[namusyaka]

@epergo Thanks for your contribution.

I think you can simply put an exceptional message in mustermann/lib/mustermann/extension.rb, and then you can restore only extend_object without register Extension.
At least you should consider a case that requires mustermann/extension

[epergo]

@epergo Thanks for your contribution.

I think you can simply put an exceptional message in mustermann/lib/mustermann/extension.rb, and then you can restore only extend_object without register Extension.
At least you should consider a case that requires mustermann/extension

Updated in dcbf027 WDYT?

[zzak]

Is this code called from anywhere? It seems we want to remove the require in this method 🤔

[rkh]

If I'm not mistaken, Sinatra's register method calls extend, which calls extend_object.

[epergo]

Correct it is used here

[epergo]

@zzak Do you want me to do any change? Maybe I missed the point.

[zzak]

@epergo Sorry, I was just wondering out loud nothing actionable -- but I think it'd be good to test this out a bit before we release anything

[olleolleolle]

@epergo Hi 👋 ! This is awesome, and shows a way forward for mustermann + 3.0. Does it still work? (GitHub Actions' logs are purged, swept away.)

[epergo]

@epergo Hi 👋 ! This is awesome, and shows a way forward for mustermann + 3.0. Does it still work? (GitHub Actions' logs are purged, swept away.)

I've updated the PR with master, ruby 3.0 job still fails because of 1 test and the coverage report