Issue 1548 (sinatra) Describe raise_errors better in README and configuration #305
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dentarg
reviewed
Jun 24, 2023
Comment on lines
+249
to
+253
| The behavior of `:raise_errors` for unhandled errors depends on environment | ||
| when set to `true`. If the environment is `production`, the HTTP response body | ||
| will contain a generic error message, e.g. `"An unhandled lowlevel error | ||
| occurred. The application logs may have details."` If the environment is not | ||
| `production`, the HTTP response body will contain the verbose error backtrace. |
There was a problem hiding this comment.
I wonder of this isn't describing the behaviour of Puma? (which is about to be tweaked with puma/puma#3094)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is sibling work for what was done in sinatra/sinatra#1917
I summarized the changes in a less verbose way in the configuraiton.markdown file.
I believe I have followed the instructions and done the required steps, but please let me know if anything else is necessary. Thanks.