DEVEXP-785: Numbers API - Snippets #2
Conversation
| number_type="LOCAL" | ||
| ) | ||
| page_counter = 1 | ||
| while active_numbers: |
There was a problem hiding this comment.
Let me check if I understand correctly: this will evaluate to True only is the API call is successful. Then you'll enter in the loop and start displaying the numbers page by page.
active_numbers will be updated within the loop and should always be evaluated to True as long as the API answers properly.
But in the case there is an error with the API, wouldn't the SDK raise an error? If so, then it would mean this loop is unreachable.
All of this to say: wouldn't it be more readable to use while True: ?
| @@ -0,0 +1,7 @@ | |||
| def execute(numbers_service): | |||
| phone_number = "YOUR_PHONE_NUMBER" | |||
There was a problem hiding this comment.
It shouldn't be "YOUR" phone number but "A" phone number as at this moment, you haven't rented it yet
|
|
||
|
|
||
| def execute(numbers_service): | ||
| phone_number = "YOUR_PHONE_NUMBER" |
There was a problem hiding this comment.
Same here. I just checked what I did in the node.js snippets and I call it available_phone_number_to_be_rented
| voice_configuration: VoiceConfigurationDictType = { | ||
| "app_id": "YOUR_APP_ID", | ||
| } |
There was a problem hiding this comment.
Although it's not mandatory for backward compatibility reasons, I think it's best to showcase the type property too (RTC for the app_id use case)
Note for myself: do it too for Node.js :D
| def callback_configuration_get(numbers_service): | ||
| response = numbers_service.callback_configuration.get() | ||
|
|
||
| print("Callback Configuration:", response) |
matsk-sinch
force-pushed
the
DEVEXP_785-Python-Snippets
branch
from
4047dfc to
3c1f783
Compare
|
Created an orphan branch |
No description provided.