Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prefer-global-this: Also exclude outerWidth and outerHeight #2549

Merged
merged 1 commit into from
Feb 1, 2025

Conversation

fregante
Copy link
Collaborator

@fregante fregante commented Feb 1, 2025

I forgot to add these two.

Also it would be great to add a main branch protection o this repo because I almost clicked "commit to main". Admins can be exempted.

@sindresorhus sindresorhus changed the title prefer-global-this - Also exclude outerWidth and outerHeight prefer-global-this: Also exclude outerWidth and outerHeight Feb 1, 2025
@sindresorhus
Copy link
Owner

Also it would be great to add a main branch protection o this repo because I almost clicked "commit to main". Admins can be exempted.

Rules are not advanced enough to create exceptions for certain users.

@fregante
Copy link
Collaborator Author

fregante commented Feb 1, 2025

They've been for quite a while. Also admins also have a checkbox to bypass. Refined GitHub also has limitations but I can still push directly to it

/ main ↑1 ❱ git push
Enumerating objects: 9, done.
Counting objects: 100% (9/9), done.
Delta compression using up to 10 threads
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 476 bytes | 476.00 KiB/s, done.
Total 5 (delta 4), reused 0 (delta 0), pack-reused 0
remote: Resolving deltas: 100% (4/4), completed with 4 local objects.
remote: Bypassed rule violations for refs/heads/main:
remote: 
remote: - 5 of 5 required status checks are expected.
remote: 
To https://github.com/refined-github/refined-github.git
   12cd93e5..4184b99e  main -> main

@fregante fregante merged commit 8f00f76 into main Feb 1, 2025
35 checks passed
@fregante fregante deleted the prefer-global-this-outer branch February 1, 2025 19:58
Repository owner deleted a comment from g9K5ZTr0 Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants