Fix: show toolbar on double tap in QuillEditor#2600
Open
shivansh00011 wants to merge 2 commits intosingerdmx:masterfrom
Open
Fix: show toolbar on double tap in QuillEditor#2600shivansh00011 wants to merge 2 commits intosingerdmx:masterfrom
shivansh00011 wants to merge 2 commits intosingerdmx:masterfrom
Conversation
…ste field/context menu doesn't appear on double tap - Modifies selection overlay disposal logic to allow toolbar display when selection is collapsed - Adds test to verify double tap toolbar functionality - Matches behavior of Flutter's native TextField
Collaborator
|
Thanks for your contribution.
LGTM, but was an AI used to solve this issue? |
Author
Thanks man. Yeah a little help was taken but not Fully thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
Issue: Double tap on text in QuillEditor doesn't show the paste field/context menu, unlike Flutter's native TextField.
Related Issue: Issue #2594
�� Problem Analysis
When users double-tap on text in QuillEditor:
The issue occurs because the selection overlay is disposed immediately when the selection becomes collapsed after word selection, preventing the toolbar from being displayed.
🛠️ Solution
Modified the
_updateOrDisposeSelectionOverlayIfNeeded()method inlib/src/editor/raw_editor/raw_editor_state.dartto:Key Changes
✅ Testing
test/double_tap_toolbar_test.dartverifies toolbar appears on double tap🎯 Impact
📋 Checklist
🔗 Related