Skip to content

Fixed bug with broswer in dark mode. - #106

Open
RobertKihlborg wants to merge 1 commit into
single-spa:mainfrom
RobertKihlborg:main
Open

Fixed bug with broswer in dark mode. #106
RobertKihlborg wants to merge 1 commit into
single-spa:mainfrom
RobertKihlborg:main

Conversation

@RobertKihlborg

Copy link
Copy Markdown

Fixed bug where browser in dark mode resulted in white text on white background in dialog box.

Also fixed a broken test that specified exact error formatting that was not the formatting given when running with the exact packages in the lockfile.

…background in dialog box. Also fixed a broken test that specified exact error formatting that was not the formatting given when running with the exact packages in the lockfile.
@changeset-bot

changeset-bot Bot commented Jun 5, 2024

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: e09b09a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
import-map-overrides Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RobertKihlborg

Copy link
Copy Markdown
Author

The dark-mode bug could also be fixed by explicitly setting color to black in the same place where background is set to white.

@internettrans

Copy link
Copy Markdown
Member

Which browser? I tried Chrome dark mode and didn't see an issue

@ggascoigne

Copy link
Copy Markdown

I'd love to see this merged. I just (finally) switched from 2.2.0 to latest, and have the white text on white text background on the dialog, and as far as I can see there's no exposed way to fix it (since the only part exposed is the main on/off button).

CleanShot 2025-12-02 at 11 12 23

This is on Chrome, where the app is in dark mode. I feel that you should either override the background-color and the color, or neither, but only doing one rather breaks things at times (and this is one of them).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants