Bump cookie to 1.0.2 and add server-api tests - #135
Merged
Conversation
🦋 Changeset detectedLatest commit: 67c269a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Author
@jolyndenning, I added unit tests for the server-api. Would that satisfy the requirements for tests? |
|
@jolyndenning Can we get this PR merged please? This is a production security vulnerability that I think a lot of people would like to get resolved. |
internettrans
requested changes
Mar 30, 2025
internettrans
left a comment
internettrans
left a comment
Member
There was a problem hiding this comment.
NodeJS 18 requirement and change in return type for the parse function is breaking
internettrans
approved these changes
Mar 31, 2025
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: UIEN-6724, UIEN-7322