Skip to content

chore: adjust UI of table list in imo status column #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vctqs1 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: adjust UI of table list in imo status column #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ui/import-map-overrides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,13 +128,6 @@
margin-top: 32px;
}

.imo-overrides-table tr td:first-child {
display: flex;
align-items: center;
padding-right: 32px;
position: relative;
}

.imo-needs-refresh {
position: absolute;
right: 8px;
Expand All @@ -147,6 +140,13 @@
background-position: center;
}

.imo-status-wrapper {
display: flex;
align-items: center;
padding-right: 32px;
position: relative;
}

.imo-status {
height: 16px;
width: 16px;
Expand Down
58 changes: 38 additions & 20 deletions src/ui/list/list.component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,11 @@ export default class List extends Component {
key={mod.moduleName}
>
<td onClick={this.reload} role="button" tabIndex={0}>
<div className="imo-status imo-next-override" />
<div>Inline Override</div>
<div className="imo-needs-refresh" />
<div className="imo-status-wrapper">
<div className="imo-status imo-next-override" />
<div>Inline Override</div>
<div className="imo-needs-refresh" />
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand All @@ -229,9 +231,11 @@ export default class List extends Component {
key={mod.moduleName}
>
<td style={{ position: "relative" }}>
<div className="imo-status imo-next-default" />
<div>Default</div>
<div className="imo-needs-refresh" />
<div className="imo-status-wrapper">
<div className="imo-status imo-next-default" />
<div>Default</div>
<div className="imo-needs-refresh" />
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand All @@ -246,8 +250,10 @@ export default class List extends Component {
key={mod.moduleName}
>
<td>
<div className="imo-status imo-disabled-override" />
<div>Override disabled</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-disabled-override" />
<div>Override disabled</div>
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand All @@ -262,8 +268,10 @@ export default class List extends Component {
key={mod.moduleName}
>
<td>
<div className="imo-status imo-current-override" />
<div>Inline Override</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-current-override" />
<div>Inline Override</div>
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand Down Expand Up @@ -295,8 +303,10 @@ export default class List extends Component {
title="Automatically use dev version of certain npm libs"
>
<td>
<div className="imo-status imo-dev-lib-override" />
<div>Dev Lib Override</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-dev-lib-override" />
<div>Dev Lib Override</div>
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand All @@ -311,8 +321,10 @@ export default class List extends Component {
key={mod.moduleName}
>
<td>
<div className="imo-status imo-default-module" />
<div>Default</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-default-module" />
<div>Default</div>
</div>
</td>
<td>{mod.moduleName}</td>
<td>{toDomain(mod)}</td>
Expand Down Expand Up @@ -340,8 +352,10 @@ export default class List extends Component {
key={url}
>
<td>
<div className="imo-status imo-disabled-override" />
<div>Invalid</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-disabled-override" />
<div>Invalid</div>
</div>
</td>
<td>{url}</td>
</tr>
Expand All @@ -356,8 +370,10 @@ export default class List extends Component {
key={url}
>
<td>
<div className="imo-status imo-next-override" />
<div>Pending refresh</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-next-override" />
<div>Pending refresh</div>
</div>
</td>
<td>{url}</td>
</tr>
Expand All @@ -372,8 +388,10 @@ export default class List extends Component {
key={url}
>
<td>
<div className="imo-status imo-current-override" />
<div>Override</div>
<div className="imo-status-wrapper">
<div className="imo-status imo-current-override" />
<div>Override</div>
</div>
</td>
<td>{url}</td>
</tr>
Expand Down