refactor: side Flex 마이그레이션을 위한 테스트 추가 및 1유형 wrapper 전환 - #185
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
KYBee
force-pushed
the
refact/replace-scss-flex-to-side-flex
branch
from
April 25, 2026 08:47
8227f87 to
4e62898
Compare
KYBee
marked this pull request as draft
April 25, 2026 08:51
3 tasks
KYBee
force-pushed
the
refact/replace-scss-flex-to-side-flex
branch
from
April 26, 2026 11:04
a31c33c to
2cf7c19
Compare
KYBee
marked this pull request as ready for review
April 26, 2026 11:09
Collaborator
Collaborator
|
내부 삼항 연산자를 지우고 그냥 className={styles.videoCards} 로 두면 해결됩니다. |
Contributor
Author
|
@G-hoon 님 리뷰 감사합니다~ 코멘트를 제가 안 남겼었군요 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor: side Flex 마이그레이션을 위한 테스트 추가 및 1유형 wrapper 전환
작업 내용
sipe.team에 Vitest 기반 컴포넌트 테스트 환경을 추가했습니다.@sipe-team/side의Flex로 전환하는 1유형 마이그레이션을 적용했습니다.변경 사항
RecruitmentSummarySkeletonPeopleActivityActivitiesSectionCardRecruitBarChart확인 사항
corepack yarn test기준 테스트 통과sipe.team내@sipe-team/sideFlex사용 방식과 동일한 방향으로 적용