fix(agent): include SystemParts in token estimation and add reasoning guards#2014
Open
badgerbees wants to merge 1 commit intosipeed:mainfrom
Open
fix(agent): include SystemParts in token estimation and add reasoning guards#2014badgerbees wants to merge 1 commit intosipeed:mainfrom
badgerbees wants to merge 1 commit intosipeed:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
This PR fixes a deficiency in the token estimation logic for context pruning. Currently, the agent ignores
SystemParts(structured system blocks used for cache-aware adapters and large instructions), leading to underestimated token counts and potential context window overflows (400 errors). It also streamlines the reasoning content path for better robustness.🗣️ Type of Change
🤖 AI Code Generation
🔗 Related Issue
N/A
📚 Technical Context (Skip for Docs)
estimateMessageTokens,msg.SystemPartswas being ignored. Large instructions or RAG indices kept in system messages would stay hidden from the budget checker, causing overflows on the next provider call.🧪 Test Environment
📸 Evidence (Optional)
Click to view Logs/Screenshots
☑️ Checklist