fix(frontend): align dm_scope options with backend constants#2034
Open
Huangting-xy wants to merge 1 commit intosipeed:mainfrom
Open
fix(frontend): align dm_scope options with backend constants#2034Huangting-xy wants to merge 1 commit intosipeed:mainfrom
Huangting-xy wants to merge 1 commit intosipeed:mainfrom
Conversation
- Replace "per-channel" with "per-account-channel-peer" (backend supports this) - Replace "global" with "main" to match backend DMScope constant - This fixes the mismatch between frontend and backend session scope options Backend DMScope constants: - main - per-peer - per-channel-peer - per-account-channel-peer Previously frontend had: - per-channel (not recognized by backend) - per-peer ✓ - per-channel-peer ✓ - global (not recognized by backend, should be "main") Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Duplicate of #1993 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1992
Problem
The frontend
dm_scopeoptions did not match backendDMScopeconstants, causing potential issues:Frontend options:
per-channel-peer✓per-channel❌ (not recognized by backend)per-peer✓global❌ (not recognized by backend)Backend DMScope constants:
main❌ (missing from frontend)per-peer✓per-channel-peer✓per-account-channel-peer❌ (missing from frontend)Impact
per-channelorglobalin frontend would have their config sent to backend with unrecognized valuesmainscope for unrecognized values, causing unexpected behaviorper-account-channel-peeroption (supported by backend) was not available in frontendSolution
per-channelwithper-account-channel-peerto expose a backend-supported optionglobalwithmainto match backend DMScope constantFiles Changed
web/frontend/src/components/config/form-model.ts