fix(build): detect Windows shells in Makefile outputs#2051
Open
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Open
fix(build): detect Windows shells in Makefile outputs#2051Alix-007 wants to merge 2 commits intosipeed:mainfrom
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Conversation
Contributor
Author
|
CI is now green on head . The patch is limited to the Windows shell detection fix the issue describes; a maintainer review whenever convenient would be appreciated so we can move this into passive watch. |
Contributor
Author
|
CI is now green on head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
uname -svalues as Windows in the top-level Makefile.exeoutput names and Windows-friendly symlink aliases for bothbuildandbuild-launchertargetsValidation
make -n build UNAME_S=MINGW64_NT-10.0-19045 UNAME_M=x86_64make -n build-launcher UNAME_S=MINGW64_NT-10.0-19045 UNAME_M=x86_64make -n build UNAME_S=Linux UNAME_M=x86_64Closes #2050