Skip to content

fix(dingtalk): honor mention-only groups and strip leading mentions#2054

Open
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Alix-007:fix/issue-1895-channel-no-response
Open

fix(dingtalk): honor mention-only groups and strip leading mentions#2054
Alix-007 wants to merge 2 commits intosipeed:mainfrom
Alix-007:fix/issue-1895-channel-no-response

Conversation

@Alix-007
Copy link
Contributor

Summary

Fix a confirmed DingTalk no-response path behind issue #1895.

Changes

  • use DingTalk callback isInAtList when evaluating group_trigger.mention_only
  • strip leading @... tokens before routing and command handling so mentioned commands like @bot /help reach the built-in command path as /help
  • fall back to senderId / conversationId when senderStaffId is empty for direct-message routing
  • add focused tests for mention-only group delivery, mention stripping, and direct-message ID fallback

Validation

  • go test ./pkg/channels/dingtalk
  • go test ./pkg/commands
  • go test ./pkg/channels

Issue tracking

@sipeed-bot sipeed-bot bot added type: bug Something isn't working domain: channel labels Mar 26, 2026
@Alix-007
Copy link
Contributor Author

@alexhoshina CI is green on the current head. This PR only addresses the DingTalk side of #1895 and intentionally keeps the Feishu side open. A maintainer review would be appreciated when convenient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

domain: channel type: bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant