Load notification images as raw data from main process #200
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve #191 by fetching each user avatar image through the main process, using a proxy if configured for a particular account, then using Electron IPC to pass the raw image data to the renderer process and inject it dynamically into the DOM.
This uses the technique described in this SO answer: https://stackoverflow.com/a/77178841/1877316
To do
This works for the public images, but doesn't work for the proxied GitHub Enterprise server images and I'm not sure why. It seems that the problem might be the fetching itself; the web server looks like it might be returning a generic "image not found" image for each one.
Ah, I think it's because not only do the images require being proxied, they require having a logged-in session to the http server for the Enterprise instance! I wonder if we can somehow use Octokit to fetch the images?