Skip to content

Automatic required flag on FormControl elements using Validators.required#367

Merged
pennal merged 5 commits into
mainfrom
feature/apply-asterisk-with-validator
Jun 4, 2025
Merged

Automatic required flag on FormControl elements using Validators.required#367
pennal merged 5 commits into
mainfrom
feature/apply-asterisk-with-validator

Conversation

@pennal

@pennal pennal commented Jun 2, 2025

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

No linked issue, discussed directly with the core team

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This changes applies the required flag automatically when using FormControl and Validators.required. Needs to be enabled through library configuration.

It also creates a mechanism for library configuration that could be used in the future for other features.

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@pennal
pennal requested review from colinscz and ibirrer June 2, 2025 12:02
Comment thread libraries/ui-library-angular/src/lib/ui-library-angular-config.ts Outdated
Comment thread libraries/ui-library-angular/src/lib/control-value-accessors/value-accessor.ts Outdated
Comment thread libraries/ui-library-angular/src/lib/control-value-accessors/value-accessor.ts Outdated
Comment thread docs/changelog.md
@ibirrer
ibirrer self-requested a review June 4, 2025 06:12
@pennal
pennal merged commit 46b20af into main Jun 4, 2025
1 check passed
@colinscz
colinscz deleted the feature/apply-asterisk-with-validator branch December 1, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants