Skip to content

fix: timepicker value gets cleared while typing #394 - #396

Merged
colinscz merged 3 commits into
mainfrom
bugfix/timepicker-clearing-issue
Aug 4, 2025
Merged

fix: timepicker value gets cleared while typing #394#396
colinscz merged 3 commits into
mainfrom
bugfix/timepicker-clearing-issue

Conversation

@colinscz

@colinscz colinscz commented Jul 28, 2025

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

#394

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This fixes an issue with the timepicker, where when the user selects (highlights with cursor) the currently set value and starts typing (without pressing delete/clearing the previous value) to change the value, it completely disappears/gets cleared.

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@ibirrer
ibirrer force-pushed the bugfix/timepicker-clearing-issue branch from 6f9348e to 8916483 Compare July 30, 2025 09:35
@colinscz
colinscz marked this pull request as ready for review August 4, 2025 08:19
@colinscz
colinscz requested a review from ibirrer August 4, 2025 08:19
@colinscz
colinscz merged commit a9979af into main Aug 4, 2025
1 check passed
@colinscz
colinscz deleted the bugfix/timepicker-clearing-issue branch August 4, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants