Skip to content

fix: remove demo styling that causes rendering issues in the docs - #400

Merged
colinscz merged 2 commits into
mainfrom
bugfix/select-docs-rendering
Aug 27, 2025
Merged

fix: remove demo styling that causes rendering issues in the docs#400
colinscz merged 2 commits into
mainfrom
bugfix/select-docs-rendering

Conversation

@davidemarcoli

Copy link
Copy Markdown
Member

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Resolves issues where the select docs didn't render in v5

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@davidemarcoli davidemarcoli self-assigned this Aug 14, 2025
@davidemarcoli
davidemarcoli force-pushed the bugfix/select-docs-rendering branch from 3ae33af to 2550362 Compare August 14, 2025 06:35

@colinscz colinscz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks now much better, but I can observe a weird behaviour in local. Once I clicked through a couple of component pages I can click on other pages but the navigation doesn't seem to work anymore. The path in the address bar is updated but the navigation jump is not done.

@davidemarcoli can you reproduce this on your side?

@colinscz

Copy link
Copy Markdown
Collaborator

There seems to be still an issue with the virtual scrolling example at least in Firefox (but was already there before):
image

@davidemarcoli

Copy link
Copy Markdown
Member Author

It looks now much better, but I can observe a weird behaviour in local. Once I clicked through a couple of component pages I can click on other pages but the navigation doesn't seem to work anymore. The path in the address bar is updated but the navigation jump is not done.

@davidemarcoli can you reproduce this on your side?

Yes, I can reproduce it. six-root seems to be the problem

@davidemarcoli

Copy link
Copy Markdown
Member Author

There seems to be still an issue with the virtual scrolling example at least in Firefox (but was already there before): image

Also happens on Edge. It's probably because we set the options after the component is created so the validation method already ran once before we set the options.

@davidemarcoli
davidemarcoli force-pushed the bugfix/select-docs-rendering branch from 1f444d3 to be31db9 Compare August 14, 2025 13:11
@davidemarcoli
davidemarcoli force-pushed the bugfix/select-docs-rendering branch from be31db9 to c41b6a0 Compare August 14, 2025 13:51
@colinscz
colinscz merged commit 0052ba1 into main Aug 27, 2025
1 check passed
@colinscz
colinscz deleted the bugfix/select-docs-rendering branch August 27, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants