Skip to content

fix #341 cleanup css six-spinner - #443

Merged
stefan-laux merged 4 commits into
mainfrom
bugfix/341-six-spinner-css-cleanup
Nov 19, 2025
Merged

fix #341 cleanup css six-spinner#443
stefan-laux merged 4 commits into
mainfrom
bugfix/341-six-spinner-css-cleanup

Conversation

@stefan-laux

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

#341

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Cleanup CSS and fix alignement bug.

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "fix" section inside docs/changelog.md explaining the changes I contributed

Other information:

@stefan-laux stefan-laux self-assigned this Nov 17, 2025

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR successfully addresses issue #341 by cleaning up and simplifying the CSS for the six-spinner component, fixing alignment issues where the container dimensions didn't match the SVG size and position.

Key Changes:

  • Simplified CSS architecture by replacing fixed pixel dimensions (40px) with relative em units based on font-size
  • Removed complex and conflicting positioning logic (transforms, relative positioning with offsets)
  • Updated all documentation to use consistent inline font-size styling instead of IDs with CSS part selectors

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
libraries/ui-library/src/components/six-spinner/six-spinner.scss Removed complex positioning and fixed dimensions; simplified to use 1em sizing with font-size: 40px default, removed unused color variable
libraries/ui-library/src/components/six-spinner/index.html Updated size examples to use inline font-size styles (3.5rem, 5rem) instead of IDs with CSS part selectors
docs/examples/docs-demo-six-spinner-1.vue Updated Vue demo to match HTML examples with inline font-size styles
docs/components/six-spinner.md Updated documentation to reflect new sizing approach with inline styles
docs/changelog.md Added fix entry for container/SVG size and position mismatch

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@colinscz
colinscz self-requested a review November 18, 2025 12:59
colinscz
colinscz previously approved these changes Nov 18, 2025

@colinscz colinscz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

Comment thread docs/changelog.md Outdated
Co-authored-by: Colin S. <19342760+colinscz@users.noreply.github.com>
@stefan-laux
stefan-laux merged commit 5bdd528 into main Nov 19, 2025
2 checks passed
@stefan-laux
stefan-laux deleted the bugfix/341-six-spinner-css-cleanup branch November 19, 2025 07:41
@pennal pennal added this to the v5.2.0 milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants