fix #341 cleanup css six-spinner - #443
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR successfully addresses issue #341 by cleaning up and simplifying the CSS for the six-spinner component, fixing alignment issues where the container dimensions didn't match the SVG size and position.
Key Changes:
- Simplified CSS architecture by replacing fixed pixel dimensions (40px) with relative
emunits based onfont-size - Removed complex and conflicting positioning logic (transforms, relative positioning with offsets)
- Updated all documentation to use consistent inline
font-sizestyling instead of IDs with CSS part selectors
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
libraries/ui-library/src/components/six-spinner/six-spinner.scss |
Removed complex positioning and fixed dimensions; simplified to use 1em sizing with font-size: 40px default, removed unused color variable |
libraries/ui-library/src/components/six-spinner/index.html |
Updated size examples to use inline font-size styles (3.5rem, 5rem) instead of IDs with CSS part selectors |
docs/examples/docs-demo-six-spinner-1.vue |
Updated Vue demo to match HTML examples with inline font-size styles |
docs/components/six-spinner.md |
Updated documentation to reflect new sizing approach with inline styles |
docs/changelog.md |
Added fix entry for container/SVG size and position mismatch |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
colinscz
self-requested a review
November 18, 2025 12:59
Co-authored-by: Colin S. <19342760+colinscz@users.noreply.github.com>
colinscz
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#341
❓ Type of change
📚 Description
Cleanup CSS and fix alignement bug.
📝 Checklist
mainbranchfix #xxx[,#xxx], where "xxx" is the issue number)Other information: