Skip to content

fix #336 drag and drop bug - #444

Merged
stefan-laux merged 3 commits into
mainfrom
bugfix/336-fix-file-upload-drop-event
Nov 18, 2025
Merged

fix #336 drag and drop bug#444
stefan-laux merged 3 commits into
mainfrom
bugfix/336-fix-file-upload-drop-event

Conversation

@stefan-laux

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

#336

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

fix drag and drop bug

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "fix" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a drag and drop bug in the six-file-upload component where dropped files were not being processed. The fix adds event parameter typing and proper file handling when files are dropped onto the upload component.

Key Changes

  • Added DragEvent parameter to the dropHandler method
  • Implemented file handling logic to process dropped files via event.dataTransfer.files
  • Updated changelog to document the fix

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
libraries/ui-library/src/components/six-file-upload/six-file-upload.tsx Added event parameter and file processing logic to the drop handler to properly handle dragged files
docs/changelog.md Documented the drag and drop bug fix in the changelog

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/changelog.md Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@davidemarcoli davidemarcoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, weird that there wasn't anything in there

@colinscz
colinscz self-requested a review November 18, 2025 12:52

@colinscz colinscz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@stefan-laux
stefan-laux merged commit 92fb7a6 into main Nov 18, 2025
2 checks passed
@stefan-laux
stefan-laux deleted the bugfix/336-fix-file-upload-drop-event branch November 18, 2025 15:43
@pennal pennal added this to the v5.2.0 milestone Nov 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants