fix #336 drag and drop bug - #444
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a drag and drop bug in the six-file-upload component where dropped files were not being processed. The fix adds event parameter typing and proper file handling when files are dropped onto the upload component.
Key Changes
- Added
DragEventparameter to thedropHandlermethod - Implemented file handling logic to process dropped files via
event.dataTransfer.files - Updated changelog to document the fix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| libraries/ui-library/src/components/six-file-upload/six-file-upload.tsx | Added event parameter and file processing logic to the drop handler to properly handle dragged files |
| docs/changelog.md | Documented the drag and drop bug fix in the changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
davidemarcoli
approved these changes
Nov 17, 2025
davidemarcoli
left a comment
Member
There was a problem hiding this comment.
Looks good, weird that there wasn't anything in there
colinscz
self-requested a review
November 18, 2025 12:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#336
❓ Type of change
📚 Description
fix drag and drop bug
📝 Checklist
mainbranchfix #xxx[,#xxx], where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: