Skip to content

chore: address issue with github pages permission and switch publish setup for regular release - #455

Merged
colinscz merged 4 commits into
mainfrom
fix/github-pages-deployment
Dec 1, 2025
Merged

chore: address issue with github pages permission and switch publish setup for regular release#455
colinscz merged 4 commits into
mainfrom
fix/github-pages-deployment

Conversation

@colinscz

@colinscz colinscz commented Dec 1, 2025

Copy link
Copy Markdown
Collaborator

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR fixes the issue with the deployment to Github pages and removes the npm token authentication on the regular release:

📝 Checklist

  • I have linked an issue or discussion.
  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • I have updated the documentation accordingly.
  • All tests are passing
  • New/updated tests are included
  • I have updated the "upcoming" section inside docs/changelog.md explaining the changes I contributed

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@colinscz colinscz changed the title fix: issue with github pages build fix: issue with github pages build permission Dec 1, 2025
@colinscz colinscz changed the title fix: issue with github pages build permission chore: fix issue with github pages permission and switch publish setup for regular release Dec 1, 2025
@colinscz colinscz changed the title chore: fix issue with github pages permission and switch publish setup for regular release chore: address issue with github pages permission and switch publish setup for regular release Dec 1, 2025
@colinscz colinscz self-assigned this Dec 1, 2025
@colinscz
colinscz requested a review from pennal December 1, 2025 14:50

@pennal pennal left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am preemptively approving the changes and counting on your best judgement 🙃

Comment thread .github/workflows/release.yml
Comment thread .github/workflows/release.yml
@colinscz
colinscz merged commit e3937db into main Dec 1, 2025
2 checks passed
@colinscz
colinscz deleted the fix/github-pages-deployment branch December 1, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants