Remove default values for remote and local #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually run the tests on Travis Thanks @bergie
Updating build link to point to my travis CI build
…ess has to be started which is a PIA)
…ntomjs and only load the local file
|
+1, thanks this, I kept wondering why it was taking screenshots of the localhost when I had removed it from the options |
mauron85
added a commit
to mauron85/grunt-autoshot
that referenced
this pull request
Jul 4, 2015
- remove default values for remote and local - Actually run the tests on Travis - Merge pull request siygle#1 from bergie/patch-1 - Fixing JSHint errors - Fixing up broken test by checking in image (otherwise a seperate process has to be started which is a PIA) - Trying comparison of base64 encoding as travis seems to fail with binary comparison - Trying to regenerate file each time using grunt-shell to kick off phantomjs and only load the local file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4