fix: Move the context menu listener to the root level to avoid the te…

…rminated issue
siygle · May 10, 2024 · 8d7b64c · 8d7b64c
1 parent 7f53050
commit 8d7b64c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 12 deletions.
diff --git a/background.js b/background.js
@@ -14,19 +14,12 @@ chrome.runtime.onInstalled.addListener(function () {
       id: context
     });
   }
-  // Intentionally create an invalid item, to show off error checking in the
-  // create callback.
-  chrome.contextMenus.create(
-    { title: 'Oops', parentId: 999, id: 'errorItem' },
-    function () {
-      if (chrome.runtime.lastError) {
-        console.log('Got expected error: ' + chrome.runtime.lastError.message);
-      }
-    }
-  );
-  chrome.contextMenus.onClicked.addListener(genericOnClick);
 });
 
+// Move the context menu listener to the root level to avoid the terminated issue
+// src: https://stackoverflow.com/a/69012673
+chrome.contextMenus.onClicked.addListener(genericOnClick);
+
 function genericOnClick(data, tab) {
   if ('page' === data.menuItemId) skeet(data.pageUrl, tab.title);
   if ('link' === data.menuItemId) skeet(data.linkUrl);

diff --git a/manifest.json b/manifest.json
@@ -1,6 +1,6 @@
 {
   "manifest_version": 3,
-  "version": "0.0.1",
+  "version": "0.0.3",
   "name": "Share on BlueSky",
   "description": "Share the current page on BlueSky",
   "icons": {