Conversation
badrogger
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes several improvements to the release workflow, enhances documentation, and updates configuration for the desktop application. The most significant changes are improved release safety checks to prevent duplicate releases, better handling of re-runs, and small updates to the project's documentation and configuration.
Release workflow improvements:
.github/workflows/desktop-release.ymlto refuse duplicate releases unless the commit is identical, preventing wasted build time and surfacing errors earlier..github/workflows/desktop-release.ymlto explicitly setGH_REPOsince the job doesn't check out the repository, ensuring the GitHub CLI works correctly..github/workflows/desktop-release.ymlto replace assets for the same commit instead of failing, allowing safe re-runs of failed publish jobs..github/workflows/release.yaml, ensuredGITHUB_REFandGITHUB_SHAreflect the triggering branch/commit for workflow runs, making semantic-release work correctly on workflow_run events.Documentation updates:
README.md. [1] [2]Configuration updates:
pubkeyindesktop/src-tauri/tauri.conf.json, likely to rotate or update the signing key for desktop releases.