Bug/1744 handle custom errors outside evm - #1747
Draft
olehnikolaiev wants to merge 5 commits into
Draft
Conversation
olehnikolaiev
requested review from
DmytroNazarenko and
kladkogex
as code owners
December 8, 2023 16:17
|
SUGGESTIONS BEFORE MERGE:
|
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (4.76%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1747 +/- ##
===========================================
- Coverage 45.52% 36.46% -9.07%
===========================================
Files 356 356
Lines 51685 51767 +82
===========================================
- Hits 23532 18877 -4655
- Misses 28153 32890 +4737 🚀 New features to boost your workflow:
|
kladkogex
requested changes
Dec 11, 2023
kladkogex
left a comment
Contributor
There was a problem hiding this comment.
Please make it compatible to the way it is done in geth.
In particular, for error message one simply needs to return a byte array as is.
There is no need for any processing.
Please look at geth code
DmytroNazarenko
marked this pull request as draft
October 14, 2024 16:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1744
added unittests at
test/unittests/libweb3jsonrpc/jsonrpc.cpp: revertReasonto verify handling different revert messages and custom errors