Skip to content

Bug/1744 handle custom errors outside evm - #1747

Draft
olehnikolaiev wants to merge 5 commits into
developfrom
bug/1744-handle-custom-errors-outside-evm
Draft

Bug/1744 handle custom errors outside evm#1747
olehnikolaiev wants to merge 5 commits into
developfrom
bug/1744-handle-custom-errors-outside-evm

Conversation

@olehnikolaiev

@olehnikolaiev olehnikolaiev commented Dec 8, 2023

Copy link
Copy Markdown
Contributor

fixes #1744

added unittests at test/unittests/libweb3jsonrpc/jsonrpc.cpp: revertReason to verify handling different revert messages and custom errors

@github-actions

github-actions Bot commented Dec 8, 2023

Copy link
Copy Markdown

@olehnikolaiev
olehnikolaiev changed the base branch from develop to v3.18.0 December 8, 2023 16:18
@codecov

codecov Bot commented Dec 8, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 4.76190% with 80 lines in your changes missing coverage. Please review.
✅ Project coverage is 36.46%. Comparing base (2fcb104) to head (3b6c5ab).
⚠️ Report is 3197 commits behind head on develop.

❌ Your patch check has failed because the patch coverage (4.76%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1747      +/-   ##
===========================================
- Coverage    45.52%   36.46%   -9.07%     
===========================================
  Files          356      356              
  Lines        51685    51767      +82     
===========================================
- Hits         23532    18877    -4655     
- Misses       28153    32890    +4737     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kladkogex kladkogex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make it compatible to the way it is done in geth.

In particular, for error message one simply needs to return a byte array as is.

There is no need for any processing.

Please look at geth code

Base automatically changed from v3.18.0 to develop January 22, 2024 19:07
@DmytroNazarenko
DmytroNazarenko marked this pull request as draft October 14, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle custom errors thrown by evm

2 participants