2503 refactor btrfs setup & teardown for tests - #2504
Draft
PropzSaladaz wants to merge 1 commit into
Draft
Conversation
|
SUGGESTIONS BEFORE MERGE:
|
Base automatically changed from
feature/2327-add-API-getLatestSnapshotHash
to
develop
July 30, 2026 14:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implemented a shared BTRFS test fixture helper to centralize duplicated setup/teardown logic across snapshot-related tests.
The new helper manages sudo identity switching, BTRFS image creation, mount/chown, unmount, and artifact cleanup. It also makes mount path ownership explicit, so fixed test-owned paths can be removed during cleanup while externally owned paths, such as
TransientDirectory, are only unmounted and left for their owner to delete.Updated the BTRFS-backed fixtures in
SnapshotManager,HashSnapshot,ClientSnapshots, and JSON-RPC tests to use the shared helper, reducing duplicated lifecycle code and making cleanup behavior consistent across suites.Fixes #2503