Skip to content

Conversation

ysraelcarmona
Copy link

No description provided.

Copy link
Contributor

@nover nover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution - I have a suggestion for improvement though

@@ -17,7 +17,7 @@ public void Commit(string csProjFilePath, string message)
throw new OperationCanceledException($"Unable to add cs proj file {csProjFilePath} to git index");
}

if(!LaunchGitWithArgs($"commit -m \"{message}\""))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion
Perhaps it would be wiser to add a cli-flag to dotnet version cli which allows skipping hooks?

@ysraelcarmona
Copy link
Author

ysraelcarmona commented Dec 20, 2024

I initially did that but I realise there's no point in running hook since we are just updating practically one line of a file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants