-
-
Notifications
You must be signed in to change notification settings - Fork 358
feat: tabs #3679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tabs #3679
Conversation
🦋 Changeset detectedLatest commit: 6de949f The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
I like the floating better, but why does the area between the button and the tabs be clickable? There isn't anything there, no hover, no indication of clicking there that should work. I don't see that as a bug? |
@Hugos68 it was reported as a bug by users already in v3. They couldn't figure out why they would sometimes click and it wouldn't register. Turns out they were missing the button element. But I also prefer the floating button style. So perhaps we just make the judgement call to revert and keep it like it was? |
I think they thought it was a bug because in V3 there were hover styles when hovering on the so called "dead area" those hover styles aren't present in V4, there is absolutely no reason to think it's clickable since there is no visible feedback when hovering on it. I've reverted it to floating yeah |
Linked Issue
Closes #3646
Description
Adds the Tabs component
Checklist
Please read and apply all contribution requirements.
docs/
,feature/
,chore/
,bugfix/
main
branchpnpm check
in the root of the monorepopnpm format
in the root of the monorepopnpm lint
in the root of the monorepopnpm test
in the root of the monorepo/package
projects, please supply a ChangesetChangesets
View our documentation to learn more about Changesets. To create a Changeset:
pnpm changeset
and follow the prompts