Skip to content

Conversation

Hugos68
Copy link
Contributor

@Hugos68 Hugos68 commented Sep 2, 2025

Linked Issue

Closes #3646

Description

Adds the Tabs component

Checklist

Please read and apply all contribution requirements.

  • Your branch should be prefixed with: docs/, feature/, chore/, bugfix/
  • Contributions should target the main branch
  • Documentation should be updated to describe all relevant changes
  • Run pnpm check in the root of the monorepo
  • Run pnpm format in the root of the monorepo
  • Run pnpm lint in the root of the monorepo
  • Run pnpm test in the root of the monorepo
  • If you modify /package projects, please supply a Changeset

Changesets

View our documentation to learn more about Changesets. To create a Changeset:

  1. Navigate to the root of the monorepo in your terminal
  2. Run pnpm changeset and follow the prompts
  3. Commit and push the changeset before flagging your PR review for review.

Copy link

changeset-bot bot commented Sep 2, 2025

🦋 Changeset detected

Latest commit: 6de949f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@skeletonlabs/skeleton-common Minor
@skeletonlabs/skeleton-svelte Minor
@skeletonlabs/skeleton-react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Sep 2, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
www.skeleton.dev Ready Ready Preview Comment Sep 4, 2025 2:57pm
1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
themes.skeleton.dev Ignored Ignored Sep 4, 2025 2:57pm

@Hugos68
Copy link
Contributor Author

Hugos68 commented Sep 3, 2025

I like the floating better, but why does the area between the button and the tabs be clickable? There isn't anything there, no hover, no indication of clicking there that should work. I don't see that as a bug?

@endigo9740
Copy link
Contributor

endigo9740 commented Sep 3, 2025

@Hugos68 it was reported as a bug by users already in v3. They couldn't figure out why they would sometimes click and it wouldn't register. Turns out they were missing the button element.

But I also prefer the floating button style. So perhaps we just make the judgement call to revert and keep it like it was?

@Hugos68
Copy link
Contributor Author

Hugos68 commented Sep 3, 2025

@Hugos68 it was reported as a bug by users already in v3. They couldn't figure out why they would sometimes click and it wouldn't register. Turns out they were missing the button element.

I think they thought it was a bug because in V3 there were hover styles when hovering on the so called "dead area" those hover styles aren't present in V4, there is absolutely no reason to think it's clickable since there is no visible feedback when hovering on it.

I've reverted it to floating yeah

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v4 Component: Tabs
2 participants