Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct the instructions #55

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Correct the instructions #55

merged 2 commits into from
Jan 3, 2024

Conversation

sinsukehlab
Copy link
Contributor

Summary

Just an _underscore_ makes no sense at all.

Changes

Correct the instructions by deleting the nonsense and adding a meaningful hint.

Closes:

Task list

  • For workflow changes, I have verified the Actions workflows function as expected.
  • For content changes, I have reviewed the style guide.

Copy link

@rsese rsese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@rsese rsese merged commit 0471289 into skills:main Jan 3, 2024
Copy link

@Arry-eng Arry-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Further changes are required as per comments in issue/bug #44

Copy link

@Arry-eng Arry-eng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is necessitated by the bug #44 . Please refer to the comments by @Arry-eng for details.

```markdown
_underscore_
```
1. Update the contents in the `ci` branch to get the test to pass. You need to look at the logs to see what caused the test to fail.
Copy link

@Arry-eng Arry-eng Jan 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix it, open the ci.yml file and go to the last line. Remove the dot "." in the command "npx remark . --use remark-preset-lint-consistent --frail".

  1. Make a change to the README.md file. Make sure the selected branch is "ci".
  2. Commit your changes to this branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants