Remove unit from inspection entities #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entity IDs and names should not include units (in this case km) since the unit could be converted by homeassistant (e.g. miles) in which case the entity name becomes confusing. Both are derived from the translations. Use the same name for the inspection in days and in distance, which was already the case for at least one translation. Change the icon for the inspection in distance (matching the icon for mileage) to more easily differentiate them. Do not modify the entity (translation-)keys to keep them in line with the underlying model/API responses. Fixes skodaconnect#496
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entity IDs and names should not include units (in this case km) since the unit could be converted by homeassistant (e.g. miles) in which case the entity name becomes confusing.
Both are derived from the translations.
Use the same name for the inspection in days and in distance, which was already the case for at least one translation. Change the icon for the inspection in distance (matching the icon for mileage) to more easily differentiate them.
Do not modify the entity (translation-)keys to keep them in line with the underlying model/API responses.
Fixes #496