initial tests for docker setup#453
Open
Shashankss1205 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Closes #444 . Adds Docker containerization support for sktime-mcp.
What does this implement/fix? Explain your changes.
Adds end-to-end Docker support for running sktime-mcp without any local Python setup. This includes:
New files:
Dockerfile- Multi-stage build (builder → slim runtime). The builder stage installs build tools (build-essential,gfortran,libopenblas-dev) and all Python dependencies, then only the installed packages are copied into a minimalpython:3.12-slimruntime image. Runs as a non-rootmcpuser for security..dockerignore- Filters out.git,__pycache__,.venv,docs/_build, and other dev artifacts to keep the build context small (~456KB).docker-compose.yml- Service definition with configurable environment variables (SKTIME_MCP_LOG_LEVEL,SKTIME_MCP_AUTO_FORMAT, etc.) and a namedsktime-modelsvolume for persisting saved models across container restarts.Modified files:
README.md- Added a 🐳 Docker section under Installation with build/run/compose commands and a Claude Desktop JSON config example for Docker-based MCP. Updated the project structure tree to include the new files.Makefile- Addedmake docker-buildandmake docker-runconvenience targets.Does your contribution introduce a new dependency? If yes, which one?
No new Python dependencies. Docker is the only external requirement, and it is optional - existing pip-based installation is unaffected.
What should a reviewer concentrate their feedback on?
build-essential/gfortran/libopenblas-devfor compiling numpy/scipy, but onlylibopenblas0is carried into the runtime image. Is this the right trade-off vs. a single-stage build?docker-compose.ymlusesstdin_open: truewithtty: false- this is intentional since MCP JSON-RPC needs raw stdin, not a pseudo-TTY. Worth confirming this works across Docker versions."command": "docker"with"args": ["run", "-i", "--rm", "sktime-mcp"]- reviewers familiar with MCP client setups should verify this pattern.Any other comments?
Verified end-to-end locally:
docker buildcompletes successfully (~81s)sktime-mcp v0.1.0,sktime,mcp)initializeJSON-RPC handshake succeedstools/listreturns all 22 registered toolsPR checklist
For all contributions
make check).docs/source/.examples/.