fix: preserve database dialect in SQL connection string sanitization#71
Merged
Merged
Conversation
Fixes an issue where would aggressively split on and replace everything before it with , destroying the database dialect (e.g., ). This caused the LLM agent to lose context on what SQL dialect to use when reading metadata. The new logic preserves the protocol scheme before applying the mask.
Contributor
Author
|
@Shashankss1205 ready to review :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where
_sanitize_connection_stringwould aggressively split on@and replace everything before it with***, destroying the database dialect (e.g.,postgresql://). This caused the LLM agent to lose context on what SQL dialect to use when reading metadata.The new logic preserves the protocol scheme before applying the mask.
Fixes #70