More minor test-case updates #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull-request adds a new configuration option "pause-on-newlines" which allows automatic delays on newlines, which helps for some of our test cases. For example `mbasic2.in` contains: ``` 30 NEXT I LIST RUN ``` If we let the `LIST` run it will poll for keyboard input to see if it should react to Ctrl-C, or similar, and that will swallow pending input. So we have to pause/pretend there is no input until that completes. But adding "`#LIST\n#RUN`" or similar feels fragile and confusing. Pausing after every newline will make things simpler.
…we no longer use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull-request adds a new configuration option "pause-on-newlines" which allows automatic delays on newlines, which helps for some of our test cases.
For example
mbasic2.incontains:If we let the
LISTrun it will poll for keyboard input to see if it should react to Ctrl-C, or similar, and that will swallow pending input. So we have to pause/pretend there is no input until that completes.But adding "
#LIST\n#RUN" or similar feels fragile and confusing.Pausing after every newline will make things simpler.