desktop: log which webview library actually loaded - #1459
Open
hisco wants to merge 1 commit into
Open
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
hisco
force-pushed
the
rad-304-desktop-crash-context
branch
from
August 19, 2026 14:49
c52fa01 to
50693ed
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db0ab59. Configure here.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Which rendering bugs apply to a Linux desktop session depends on the WebKitGTK build, and it had to be asked for by hand on every report. The package manager's answer is not necessarily the library that got loaded, so this reads the process's own mappings. The lookup already exists for the diagnostics snapshot. Exposing it early enough for the startup log puts it in the journal excerpt users paste into bug reports, which is what they can reach when the app will not stay open. Claude-Session: https://claude.ai/code/session_01KEyZgyPtfpXdbWqPPsTXZe
hisco
force-pushed
the
rad-304-desktop-crash-context
branch
from
August 19, 2026 16:04
ba79c41 to
4c34edf
Compare
hisco
changed the title
nadaverell
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Chasing a desktop crash on Ubuntu (#1360) meant asking the reporter which WebKitGTK build they had, because nothing in the app said so. Which rendering bugs apply depends entirely on that, and it is the first thing anyone needs.
What
One line at startup on Linux:
Read from the process's own mappings, so it reports the library that was actually loaded rather than what the package manager thinks is installed. The lookup already exists for the diagnostics snapshot; this exposes it early enough for the startup log, which is what lands in the journal excerpt people paste into bug reports — and what they can still reach when the app will not stay open.
Passive. No behaviour change, no UI, nothing to opt into.
Scope
This PR previously also carried a crash-versus-quit signal built on marker files. That half is now split out: it went through four review rounds and each one found a correctness bug in it, while this part drew none. It is not worth holding a fifteen-line, zero-finding change behind it, so the marker work will be proposed separately and judged on its own.
Testing
Covered by the existing
internal/desktopenvtests, including a fixture for the GTK4-generation library name. Builds clean for linux, windows and darwin.https://claude.ai/code/session_01KEyZgyPtfpXdbWqPPsTXZe
Note
Low Risk
Logging-only refactor with no behavior or security changes; failure to read maps simply omits the line.
Overview
Linux desktop startup logging now prints which webview
.sois actually mapped into the process (from/proc/self/maps), so journal excerpts name the WebKitGTK build without manuallddor package-manager guesses.desktopenvexposes a newWebviewLibrary()API that reuses the existing maps scan (via a smallwebviewLibrary()wrapper) sologBootEnvcan log early; diagnosticsCollect()uses the same helper instead of calling the maps parser inline. Non-Linux builds return an empty string.Reviewed by Cursor Bugbot for commit 4c34edf. Bugbot is set up for automated code reviews on this repo. Configure here.