deps(radar-app): require k8s-ui 1.13.0 for the new policy and backup types - #1462
Merged
Conversation
…types web/src/api/policy.ts type-imports six symbols from @skyhook-io/k8s-ui. Five of them do not exist in the published 1.12.0 tarball, checked with npm pack rather than by reading version numbers: PolicyCoverageResponse, PolicyQueuedResponse, CNPGCatalogUsersResponse, VeleroStoredBackupsResponse and VeleroRunMessagesResponse. Only PolicyResourceResponse is present. Published against the old floor, radar-app declares a peer range it does not compile against, and a consumer resolving that range literally gets a build failure rather than a version-number nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release prerequisite for radar 1.11.0 / radar-app 1.11.0. Blocks the
radar-app-v1.11.0tag.The problem
web/src/api/policy.tstype-imports six symbols from@skyhook-io/k8s-ui, whileweb/package.jsonstill declares a floor of>=1.12.0.Five of the six do not exist in the published 1.12.0 tarball. Checked against the artifact, not the version number:
PolicyResourceResponsePolicyCoverageResponsePolicyQueuedResponseCNPGCatalogUsersResponseVeleroStoredBackupsResponseVeleroRunMessagesResponseAll five arrive in k8s-ui 1.13.0, alongside the per-policy coverage, CloudNativePG backup destination and Velero work.
Why it matters
publish-radar-app.ymlpublishesweb/package.json'speerDependenciesverbatim. Shipped as-is, radar-app 1.11.0 would declare a peer range it does not compile against — a consumer resolving that range literally gets a build failure, not a version-number nit. npm versions are immutable, so this is not fixable after publish.Change
One line:
>=1.12.0->>=1.13.0.Same shape as #1427 last cycle.
Ordering
Must merge before
k8s-ui-v1.13.0andradar-app-v1.11.0are tagged. Both tags should land on the same commit asv1.11.0andpkg/v1.12.0.Note
Low Risk
Single dependency version floor change with no runtime logic; aligns package metadata with existing type imports before release.
Overview
Raises the
@skyhook-io/k8s-uipeer dependency floor inweb/package.jsonfrom>=1.12.0to>=1.13.0.This matches what
web/src/api/policy.tsalready imports (PolicyCoverageResponse,PolicyQueuedResponse, CNPG and Velero response types, etc.), which are not in the published 1.12.0 package. Without the bump, consumers resolving peers at 1.12.x would hit TypeScript/build failures, and the published radar-app peer range would be wrong for an immutable npm release.Reviewed by Cursor Bugbot for commit b5b93c3. Bugbot is set up for automated code reviews on this repo. Configure here.