Skip to content

Fix issues with page-alignment of RW/RX page sizes #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issues with page-alignment of RW/RX page sizes #9

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions source/skyline/inlinehook/controlledpages.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ namespace skyline::inlinehook {
if(!isClaimed) {
// get actual pages
u64 alignedSrc = ALIGN_DOWN((u64)rx, PAGE_SIZE);
size_t alignedSize = ALIGN_UP(size, PAGE_SIZE);
size_t alignedSize = ALIGN_UP((u64)rx + size, PAGE_SIZE) - alignedSrc;

// reserve space for rw pages
u64 dst;
Expand All @@ -182,7 +182,7 @@ namespace skyline::inlinehook {
// get actual pages
u64 alignedSrc = ALIGN_DOWN((u64)rx, PAGE_SIZE);
void* alignedDst = (void*) ALIGN_DOWN((u64)rw, PAGE_SIZE);
size_t alignedSize = ALIGN_UP(size, PAGE_SIZE);
size_t alignedSize = ALIGN_UP((u64)rx + size, PAGE_SIZE) - alignedSrc;

// invalidate caches
armDCacheFlush((void*)alignedDst, size);
Expand All @@ -197,4 +197,4 @@ namespace skyline::inlinehook {

}
}
};
};