Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version Packages #1564

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Version Packages #1564

merged 1 commit into from
Oct 22, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 30, 2024 •
edited
Loading

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@sl-design-system/[email protected]

Minor Changes

  • #1580 33fd543 - Improve form integration behavior

    Previously, if you had an <sl-button> with type reset or submit, it would call the <form>'s reset() or requestSubmit() methods. With this change, the same behavior now works if you only have an <sl-form> element as the parent. If both <form> and <sl-form> elements are present, then the <form> element will take precedence. This makes it a minor change.

Patch Changes

@sl-design-system/[email protected]

Minor Changes

  • #1576 b3619c7 - Improve ability to extends Dialog

    This change improves the ability to extend the Dialog component by splitting the render() method into smaller methods. This makes it easier to override specific parts of the Dialog component:

    • renderHeader(title: string, subtitle: string)
    • renderBody()
    • renderFooter()
    • renderActions()

    The renderHeader method is slightly different. If all you want to do is add a title or subtitle to the header, you can override the method and call return super.renderHeader('My title', 'My subtitle').

    To be clear: the above API is only meant to be used when you are extending the Dialog class. If you are using the <sl-dialog> element in your HTML, than you can still use the header, body, and footer slots as before.

Patch Changes

@sl-design-system/[email protected]

Minor Changes

  • #1580 33fd543 - Improve reset and submit behavior:
    • Add new requestSubmit() method on <sl-form>
    • Add sl-reset and sl-submit events on <sl-form>
    • Fix bug where resetting a form did not clear the validation messages

Patch Changes

@sl-design-system/[email protected]

Minor Changes

  • #1575 ebe4c8a - Migrate DataSource and ArrayDataSource to dedicated @sl-design-system/data-source package.

    Since these are only used in the grid component, and that component is still in draft, migrating
    this code into its own package is not considered a breaking change.

Patch Changes

  • #1567 f8c6b86 - Add ellipsizeText property to grid and column

    When set on either <sl-grid> or <sl-grid-column> (or any of their variants), the ellipsizeText property
    will render the table data using the <sl-ellipsize-text> component, which truncates text with an ellipsis when it
    overflows its container. This is useful for tables with long text that would otherwise cause row height to grow.
    The component also automatically adds a tooltip to the truncated text so that it can still be viewed.

  • #1575 ebe4c8a - Automatically render an <sl-skeleton> component in each <td> element

    When an item to be rendered equals FetchDataSourcePlaceholder, the column will render a
    skeleton component instead of the item itself. This will help users understand that the
    data is being fetched and will be displayed soon.

    You have the option to customize the skeleton component by passing custom renderer function
    to the column component. See Storybook for an example.

    You will automatically get this behavior if you use the FetchDataSource (from the
    @sl-design-system/data-source package) with the grid.

  • Updated dependencies [33fd543, 4714b36, ebe4c8a, ebe4c8a, 4714b36, 33fd543, f8c6b86]:

@sl-design-system/[email protected]

Minor Changes

  • #1575 ebe4c8a - Migrate DataSource and ArrayDataSource to dedicated @sl-design-system/data-source package.

    Since these are only used in the grid component, and that component is still in draft, migrating
    this code into its own package is not considered a breaking change.

  • #1580 33fd543 - Add new closestElementComposed DOM utility method

    This new utility method is a wrapper around HTMLElement.prototype.closest that also considers the composed tree. This makes it easier to find the closest ancestor that matches a given selector, even if the element is in a shadow tree.

Patch Changes

  • #1599 4714b36 - Fix RovingTabindexController to correctly navigate between light & shadow DOM elements

@sl-design-system/[email protected]

Minor Changes

  • #1580 33fd543 - Improve implicit form submit behavior

    Previously when you pressed enter in a text field, it would call requestSubmit() on the associated <form> element. This mimics the behavior of the native <input> element. With this change, the behavior now also works if there is only a parent <sl-form> element. If both <form> and <sl-form> elements are present, then the <form> element will take precedence. This makes it a minor change.

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

  • #1599 4714b36 - Various a11y related fixes/improvements:

    • The label was associated with the <sl-combobox> element instead of the <input> element
    • aria-selected="false" was missing on the non-selected options
    • aria-multiselectable="true" was missing on the listbox when the multiple property is set
    • Add an aria-label to the <sl-tag-list> with value "Selected options"
    • Fix validation message not being translated
    • Remove Form Associated Custom Element code in favor of native form association with <input>

  • #1551 99d6174 - Hide the placeholder when there is a selection in multiple mode

  • #1563 ae44384 - Fix missing types in NPM package

  • Updated dependencies [33fd543, 4714b36, 33fd543, ae44384]:

@sl-design-system/[email protected]

Patch Changes

  • #1575 ebe4c8a - New @sl-design-system/data-source package

    This packages provides DataSource, ArrayDataSource and FetchDataSource classes
    for managing data sources in the design system. At the moment, it is only used by the
    grid components, but it can be used in future components as well.

    DataSource and ArrayDataSource were previously part of the @sl-design-system/shared
    package, but they have been moved to this new package to make them more reusable.

    FetchDataSource is a new data source around the window.fetch() API that can be used to
    fetch data from a remote server.

  • Updated dependencies [4714b36, ebe4c8a, 33fd543]:

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

  • #1599 4714b36 - Various a11y related fixes

    <sl-tag-list>:

    • Use aria-labelledby for the tooltip instead of aria-describedby
    • Do not set an aria-label on the host element; role="list" provides enough information

    <sl-tag>:

    • Add ability to use Delete or Backspace keys to remove the tag
    • Use aria-description to describe how to remove the tag using the keyboard
    • Make the delete button have aria-hidden="true"
    • Remove tabindex from the .wrapper element in the shadow DOM

  • Updated dependencies [4714b36, 4714b36, ebe4c8a, 3ce1a3b, 33fd543]:

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

@sl-design-system/[email protected]

Patch Changes

  • #1599 4714b36 - Fix logic to not just link based on aria-describedby, but also on aria-labelledby

  • #1588 3ce1a3b - Make the lazy tooltip smarter when it comes to determining which context to use to create the <sl-tooltip> element

    With this change, when the tooltip is lazily created, it checks if the target element has a shadow root. If it does, it uses the shadow root to create the tooltip custom element. If it doesn't, it uses the root node of the target element. If there is no parent custom element, then getRootNode() will return the document, so it will do document.createElement('sl-tooltip').

    After createElement('sl-tooltip') it then checks if the tooltip has a shadow root itself. If it doesn't, it means the tooltip custom element wasn't defined. When that happens, it will log a warning on the console.

  • Updated dependencies [4714b36, ebe4c8a, 33fd543]:

@sl-design-system/[email protected]

Patch Changes

  • #1587 79261ab - updated background color with primary.25

  • #1592 ea2fc26 - Replaced background tokens with color.palette.white.base

@github-actions github-actions bot force-pushed the changeset-release/main branch 5 times, most recently from 87a303b to 0dffa54 Compare October 7, 2024 09:19
@github-actions github-actions bot force-pushed the changeset-release/main branch 6 times, most recently from 459184f to 95143cc Compare October 11, 2024 13:51
@github-actions github-actions bot force-pushed the changeset-release/main branch from 95143cc to e3da471 Compare October 18, 2024 14:33
@github-actions github-actions bot force-pushed the changeset-release/main branch from e3da471 to 5e1732e Compare October 21, 2024 16:38
@jpzwarte jpzwarte merged commit a99cb93 into main Oct 22, 2024
@jpzwarte jpzwarte deleted the changeset-release/main branch October 22, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anna-lach anna-lach Awaiting requested review from anna-lach anna-lach is a code owner

@Diaan Diaan Awaiting requested review from Diaan Diaan is a code owner

@jpzwarte jpzwarte Awaiting requested review from jpzwarte jpzwarte is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jpzwarte