Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New calendar component #1593

Merged
merged 66 commits into from
Mar 19, 2025
Merged

New calendar component #1593

merged 66 commits into from
Mar 19, 2025

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Oct 11, 2024

Fixes #1850

Copy link

changeset-bot bot commented Oct 11, 2024

🦋 Changeset detected

Latest commit: 511c94e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@sl-design-system/shared Minor
@sl-design-system/date-field Patch
@sl-design-system/format-date Minor
@sl-design-system/calendar Patch
@sl-design-system/accordion Patch
@sl-design-system/announcer Patch
@sl-design-system/avatar Patch
@sl-design-system/button Patch
@sl-design-system/checkbox Patch
@sl-design-system/data-source Patch
@sl-design-system/dialog Patch
@sl-design-system/editor Patch
@sl-design-system/emoji Patch
@sl-design-system/form Patch
@sl-design-system/format-number Patch
@sl-design-system/grid Patch
@sl-design-system/inline-message Patch
@sl-design-system/menu Patch
@sl-design-system/number-field Patch
@sl-design-system/paginator Patch
@sl-design-system/panel Patch
@sl-design-system/popover Patch
@sl-design-system/radio-group Patch
@sl-design-system/search-field Patch
@sl-design-system/select Patch
@sl-design-system/switch Patch
@sl-design-system/tabs Patch
@sl-design-system/tag Patch
@sl-design-system/text-area Patch
@sl-design-system/text-field Patch
@sl-design-system/toggle-button Patch
@sl-design-system/toggle-group Patch
@sl-design-system/tooltip Patch
@sl-design-system/tree Patch
@sl-design-system/tool-bar Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 11, 2024

🕸 Website preview

You can view a preview here (commit 511c94e317e67a58e86eff14932cf20e144e9ba6).

@jpzwarte jpzwarte changed the title New calender component New calendar component Oct 11, 2024
Copy link
Contributor

github-actions bot commented Oct 11, 2024

🕸 Storybook preview

You can view a preview here (commit 511c94e317e67a58e86eff14932cf20e144e9ba6).

@Diaan
Copy link
Collaborator

Diaan commented Mar 17, 2025

Toggling the boolean properties a bit gets you really funky results:
Also it breaks the roving tabindex in some cases.

image
image

@Diaan
Copy link
Collaborator

Diaan commented Mar 17, 2025

Navigate to a day with the keyboard navigation, then select a different month, try keyboard navigation again to select a day. It looks like the grid inside the roving tabindex isn't updated when a new month is rendered

@Diaan
Copy link
Collaborator

Diaan commented Mar 17, 2025

Screen.Recording.2025-03-17.at.12.12.10.mov

funky hover state

@jpzwarte jpzwarte merged commit fa0b85d into main Mar 19, 2025
9 of 13 checks passed
@jpzwarte jpzwarte deleted the feature/calendar branch March 19, 2025 11:35
@github-actions github-actions bot mentioned this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Date Field and Calendar] Create Draft component
3 participants