Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/1553 checkbox has redundant aria role and property #1628

Merged
merged 10 commits into from
Nov 13, 2024

Conversation

anna-lach
Copy link
Collaborator

@anna-lach anna-lach commented Nov 13, 2024

Fixes:
#1553

@anna-lach anna-lach linked an issue Nov 13, 2024 that may be closed by this pull request
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: b7eb87f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/checkbox Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@anna-lach anna-lach marked this pull request as draft November 13, 2024 11:47
Copy link
Contributor

github-actions bot commented Nov 13, 2024

🕸 Website preview

You can view a preview here (commit b7eb87f365d10c13136d749ac9dea6ab9f1b0500).

Copy link
Contributor

github-actions bot commented Nov 13, 2024

🕸 Storybook preview

You can view a preview here (commit b7eb87f365d10c13136d749ac9dea6ab9f1b0500).

@anna-lach anna-lach marked this pull request as ready for review November 13, 2024 12:56
packages/components/checkbox/src/checkbox.spec.ts Outdated Show resolved Hide resolved
packages/components/checkbox/src/checkbox.spec.ts Outdated Show resolved Hide resolved
@anna-lach anna-lach merged commit 7a62e08 into main Nov 13, 2024
10 of 13 checks passed
@anna-lach anna-lach deleted the fix/1553-checkbox-has-redundant-aria-role-and-property branch November 13, 2024 14:02
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox has redundant aria role and property
2 participants