Fix/1562 menu button submenu a11y #1777
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing' into fix/1562-menu-button-submenu-a11y
Diaan
changed the base branch from
main
to
feature/text-field-refactor-styling
anna-lach
approved these changes
Feb 13, 2025
| @@ -74,6 +87,15 @@ export const Basic: Story = { | |||
| } | |||
| }; | |||
|
|
|||
| export const Bold: Story = { | |||
| args: { | |||
There was a problem hiding this comment.
emphasis: 'bold' should be set in the story, right?
anna-lach
reviewed
Feb 13, 2025
| @@ -83,7 +83,7 @@ export class MenuButton extends ObserveAttributesMixin(ScopedElementsMixin(LitEl | |||
|
|
|||
| this.setAttributesTarget(this.button); | |||
|
|
|||
| this.button.setAttribute('aria-details', this.menu.id); | |||
| this.button.setAttribute('aria-controls', this.menu.id); | |||
There was a problem hiding this comment.
Can you please also update the documentation?
| @@ -99,6 +99,7 @@ export class MenuButton extends ObserveAttributesMixin(ScopedElementsMixin(LitEl | |||
| @keydown=${this.#onKeydown} | |||
| ?disabled=${this.disabled} | |||
| aria-expanded="false" | |||
| aria-haspopup="menu" | |||
There was a problem hiding this comment.
Can you please also update the documentation?
| this.role = this.selectable ? selectMode : 'menuitem'; | ||
| } | ||
| if (changes.has('selected')) { | ||
| this.setAttribute('aria-checked', (this.selected || false).toString()); |
There was a problem hiding this comment.
Can you please also update the documentation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.