Skip to content

Avatar improvements #2577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Sep 10, 2025
Merged

Avatar improvements #2577

merged 14 commits into from
Sep 10, 2025

Conversation

jpzwarte
Copy link
Member

@jpzwarte jpzwarte commented Sep 4, 2025 •
edited
Loading

Fixes #1872

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: aebc794

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sl-design-system/avatar Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025 •
edited
Loading

🕸 Website preview

You can view a preview here (commit aebc7948651f20d247b89e47c85cc9da33d00134).

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 4, 2025 •
edited
Loading

🕸 Storybook preview

You can view a preview here (commit aebc7948651f20d247b89e47c85cc9da33d00134).

@jpzwarte jpzwarte marked this pull request as ready for review September 4, 2025 17:55
@DanielleRameau
Copy link
Collaborator

font wieght of initials should be demibold instead of bold

@DanielleRameau
Copy link
Collaborator

DanielleRameau commented Sep 5, 2025 •
edited
Loading

in our regular badge the font-weight is regular but in the badge of avatar the font weight is demibold

@DanielleRameau
Copy link
Collaborator

the spacing between heading and subheading isn't the same as in Figma

@DanielleRameau
Copy link
Collaborator

font-size of heading isn't consistent in figma heading is 14px (md) in sm, md, lg and xl.
font-size in subheading should be 14px in XL, 2XL and 3XL (this is currently not in Figma the case but asked Roald to change this)

@RoaldBoerema
Copy link
Collaborator

RoaldBoerema commented Sep 8, 2025 •
edited
Loading

Please look at badge size and placement. Especially for the Square version, unfortunately it's not just a shape difference between circle and square.
Screenshot 2025-09-08 at 20 55 56

@RoaldBoerema
Copy link
Collaborator

RoaldBoerema commented Sep 8, 2025 •
edited
Loading

Resolved fontsize and color issues in Figma as Danielle mentioned

Diaan
Diaan requested changes Sep 10, 2025
View reviewed changes
anna-lach
anna-lach reviewed Sep 10, 2025
View reviewed changes
@jpzwarte jpzwarte merged commit 927c110 into main Sep 10, 2025
9 of 13 checks passed
@jpzwarte jpzwarte deleted the feature/1872-refactor-avatar-styling branch September 10, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Diaan Diaan Diaan approved these changes

@anna-lach anna-lach anna-lach approved these changes

@DanielleRameau DanielleRameau DanielleRameau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Avatar] Refactor to contextual tokens in code
5 participants
@jpzwarte @DanielleRameau @RoaldBoerema @Diaan @anna-lach