Add paginator and data source functionality to angular-demo app #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Diaan
commented
Sep 10, 2025
Diaan
commented
- Updated package.json to include @webcomponents/scoped-custom-element-registry and @sl-design-system/data-source dependencies.
- Enhanced app.component.ts to implement data fetching and pagination.
- Modified app.component.html to display quotes with pagination controls.
- Updated app.module.ts to import PaginatorComponent.
- Registered paginator component in main.ts.
- Adjusted polyfills.ts for scoped custom element registry.
- Updated package.json to include @webcomponents/scoped-custom-element-registry and @sl-design-system/data-source dependencies. - Enhanced app.component.ts to implement data fetching and pagination. - Modified app.component.html to display quotes with pagination controls. - Updated app.module.ts to import PaginatorComponent. - Registered paginator component in main.ts. - Adjusted polyfills.ts for scoped custom element registry.
jpzwarte
approved these changes
Sep 11, 2025
| @@ -1,2 +1,11 @@ | |||
| <h1>Hello Angular Demo!</h1> | |||
| <sl-button variant="info" size="lg">Button</sl-button> | |||
|
|
|||
| <ul> | |||
| <ng-template ngFor let-item [ngForOf]="quotes"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.