Remove the need for the async_trait crate by leveraging the native async fns support now in Rust as of v1.75
#202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slawlor
force-pushed
the
async_trait
branch
2 times, most recently
from
9152c1f to
14b2f0e
Compare
GamePad64
reviewed
Feb 17, 2024
slawlor
force-pushed
the
async_trait
branch
7 times, most recently
from
3938a14 to
6ddf015
Compare
…`async fn`s support now in Rust as of v-2.75
https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html
This PR also makes the newly supported functionality opt-in via `no-default-features` and not enabling the `async-trait` feature (and therefore dependency).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://blog.rust-lang.org/2023/12/21/async-fn-rpit-in-traits.html
This PR also makes the newly supported functionality opt-in via
no-default-featuresand not enabling theasync-traitfeature (and therefore dependency).Benchmarks show that functionality isn't generally impacted on small-scale tests, however by using
async fnnatively in the trait we risk a performance impact because this won'tBoxthe futures into aBoxFutureand won't move the future onto the heap.