Make latency measurement in ping message robust against time drift #320
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #320 +/- ##
==========================================
- Coverage 82.08% 82.08% -0.01%
==========================================
Files 61 61
Lines 12198 12206 +8
==========================================
+ Hits 10013 10019 +6
- Misses 2185 2187 +2 ☔ View full report in Codecov by Sentry. |
Time drift happens and time going backwards is common on NTP enabled servers. When time drift happens it's not worth it to kill the node session. Change the timestamp payload to use duration against NodeSession specific Instant epoch initialized at creation time. This ensures the timestamp increases monotonically. It can only go backwards when the payload is malformed. Signed-off-by: Kan-Ru Chen <kanru@kanru.info>
kanru
force-pushed
the
refactor-improve-ping-robust
branch
from
4319ce2 to
ad44a78
Compare
slawlor
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time drift happens and time going backwards is common on NTP enabled servers. When time drift happens it's not worth it to kill the node session.
Change the timestamp payload to use duration against NodeSession specific Instant epoch initialized at creation time. This ensures the timestamp increases monotonically. It can only go backwards when the payload is malformed.
Note - this makes the timestamp in the payload an offset from UNIX_EPOCH. I think it is fine and nobody should be reading the timestamp for anything useful.