Move handler methods from infallible calls to `Result<_,_>` #34

slawlor · 2023-01-27T01:45:11Z

Blocked on #32 after that merges, rebase and put up for review.

This PR moves all of the handler methods

pre_start(..)
post_start(..)
post_stop(..)
handle(..)
handle_supervision_evt(..)

to return types that return

-> Result<_, ActorProcessingErr> {}

which is type alias for

pub type ActorProcessingErr = Box<dyn std::error::Error + Send + Sync + 'static>;

which allows us to auto-convert almost anything that implements the Error trait and bubble it up to the supervisor with all associated information.

…y on the Erlang protocol. This is a collection of tcp managing actors and session management for automated session handling Related issue: #16

codecov · 2023-01-27T01:54:38Z

Codecov Report

Base: 86.18% // Head: 63.55% // Decreases project coverage by -22.64% ⚠️

Coverage data is based on head (b2bb1cc) compared to base (59e6ff8).
Patch coverage: 48.13% of modified lines in pull request are covered.

Additional details and impacted files

@@             Coverage Diff             @@
##             main      #34       +/-   ##
===========================================
- Coverage   86.18%   63.55%   -22.64%     
===========================================
  Files          25       40       +15     
  Lines        2331     5092     +2761     
===========================================
+ Hits         2009     3236     +1227     
- Misses        322     1856     +1534

Impacted Files	Coverage Δ
ractor/src/actor/errors.rs	`69.04% <0.00%> (+1.60%)`	⬆️
ractor/src/concurrency.rs	`96.42% <ø> (ø)`
ractor_cluster/src/hash.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/net/listener.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/net/session.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/node/auth.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/node/client.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/node/mod.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/node/node_session.rs	`0.00% <0.00%> (ø)`
ractor_cluster/src/remote_actor/mod.rs	`0.00% <0.00%> (ø)`
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

This change migrates changes to using `Result<_,_>` return types for actor handlers, to minimize calling `panic!`s. This additionally passes dyn Errors up to handlers so supervisors can handle extended error information cleanly. Resolves #33

slawlor · 2023-01-27T17:01:50Z

Closed in favor of #35

slawlor added 2 commits January 25, 2023 14:18

Initial sketchings of how distributed node's might look, based heavil…

0664c73

…y on the Erlang protocol. This is a collection of tcp managing actors and session management for automated session handling Related issue: #16

PG Groups lifecycle + PID lifecycle synchronization

12db101

slawlor force-pushed the results branch from 940633a to bf52aee Compare January 27, 2023 01:55

slawlor changed the title ~~Move calls to Result<_,_>~~ Move handler methods from infallible calls to Result<_,_> Jan 27, 2023

slawlor force-pushed the results branch from bf52aee to 31d3716 Compare January 27, 2023 16:19

Migrating to Result<_,_> types for handlers

b2bb1cc

This change migrates changes to using `Result<_,_>` return types for actor handlers, to minimize calling `panic!`s. This additionally passes dyn Errors up to handlers so supervisors can handle extended error information cleanly. Resolves #33

slawlor force-pushed the results branch from 31d3716 to b2bb1cc Compare January 27, 2023 16:57

slawlor closed this Jan 27, 2023

slawlor deleted the results branch January 27, 2023 17:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move handler methods from infallible calls to `Result<_,_>` #34

Move handler methods from infallible calls to `Result<_,_>` #34

slawlor commented Jan 27, 2023

codecov bot commented Jan 27, 2023 •

edited

Loading

slawlor commented Jan 27, 2023

Move handler methods from infallible calls to Result<_,_> #34

Move handler methods from infallible calls to Result<_,_> #34

Conversation

slawlor commented Jan 27, 2023

codecov bot commented Jan 27, 2023 • edited Loading

Codecov Report

slawlor commented Jan 27, 2023

Move handler methods from infallible calls to `Result<_,_>` #34

Move handler methods from infallible calls to `Result<_,_>` #34

codecov bot commented Jan 27, 2023 •

edited

Loading